Runtime: Refactor conn cache to contain and detect hanging opens/closes #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
approved these changes
Dec 15, 2023
| closed bool | ||
| mu sync.Mutex | ||
| entries map[string]*entry | ||
| lru *simplelru.LRU |
There was a problem hiding this comment.
We can also expose metrics around lru and entries size and optionally connection open and close times.
runtime/pkg/conncache/conncache.go
Outdated
| // Options configures a new connection cache. | ||
| type Options struct { | ||
| // MaxConnectionsIdle is the maximum number of non-acquired connections that will be kept open. | ||
| MaxConnectionsIdle int |
There was a problem hiding this comment.
Nit: Usually the name is MaxIdleConnections (https://pkg.go.dev/database/sql#DB.SetMaxIdleConns)
begelundmuller
deleted the
begelundmuller/refactor-conn-cache-open-close-background
branch
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
…es (#3666) * Runtime: Refactor conn cache to contain and detect hanging opens/closes * Extract connection cache to pkg + use a singleflight * Add tests * Make tests pass * increase test sleeps for clsoe * Fix various race conditions * Integrate singleflight with conncache's mutex * Increase timeouts * Better comments * Prevent deadlock when closing while opening * Address review comments * Remove redundant var
esevastyanov
pushed a commit
that referenced
this pull request
Dec 19, 2023
…es (#3666) * Runtime: Refactor conn cache to contain and detect hanging opens/closes * Extract connection cache to pkg + use a singleflight * Add tests * Make tests pass * increase test sleeps for clsoe * Fix various race conditions * Integrate singleflight with conncache's mutex * Increase timeouts * Better comments * Prevent deadlock when closing while opening * Address review comments * Remove redundant var (cherry picked from commit fa2e166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These refactors enable:
Contributes to https://github.com/rilldata/rill-private-issues/issues/17